new variables 'associate_public_ip_address' and 'target_ami_name_prefix'#65
Open
charlestjackson wants to merge 1 commit intoaws-samples:mainfrom
Open
new variables 'associate_public_ip_address' and 'target_ami_name_prefix'#65charlestjackson wants to merge 1 commit intoaws-samples:mainfrom
charlestjackson wants to merge 1 commit intoaws-samples:mainfrom
Conversation
charlestjackson
requested review from
ROunofF,
bryantbiggs,
mhawali and
niallthomson
as code owners
bryantbiggs
reviewed
Jul 18, 2023
|
|
||
| variable "ami_name_prefix" { | ||
| description = "The prefix to use when creating the AMI name. i.e. - `<ami_name_prefix>-<eks_version>-<timestamp>" | ||
| description = "The prefix identifying the source AMI to use when creating the AMI. i.e. - `<ami_name_prefix>-<eks_version>-<timestamp>" |
Contributor
There was a problem hiding this comment.
I think it would be better to just update the variable description to make it clear that its the name prefix that is used to both lookup the base AMI as well as the name prefix used for the resulting AMI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two new variables added to Packer config.
Motivation and Context
Fixes issue 64
How Has This Been Tested?
These changes were tested by running against an AWS account using a non-default VPC and a public subnet that was not configured to auto-assign public IPs.
Screenshots (if appropriate):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.